Follow-up to #2470807: Rename the default "Messages" region for all themes to "Highlighted"

Problem/Motivation

Proposed resolution

Rename the Messages region to a broader name that represents a region that provides useful information to the user.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 rename-messages-region-2471697-1.patch1.23 KBDom.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dom.’s picture

Dom. CreditAttribution: Dom. commented
FileSize
rename-messages-region-2471697-1.patch1.23 KB

Here is a patch to introduce the change of messages (Messages) region to informations (Informations) in Classy theme.
It does :
- do the change
- make sure messages block is set to informations by default
- add the usual markups for regions :

<code><div class="informations">
  <aside class="layout-container section clearfix" role="complementary">
     <div class="region region-informations">
       content of information region

NOTE: this depends on the patch https://www.drupal.org/node/2471681#comment-9826281 first !

Status: Needs review » Needs work

The last submitted patch, 1: rename-messages-region-2471697-1.patch, failed testing.

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Needs work » Postponed

Postponing this issue until a consensus is made on the new region name within the Bartik issue.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Postponed » Closed (duplicate)

Because it can be applied without parent patch, and because the fix is so easy, we will take care of it in one single issue at
#2470807: Rename the default "Messages" region for all themes to "Highlighted"

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Title: Rename the Messages region in Classy. » Rename the default Messages region for all themes
Component: Bartik theme » theme system
Status: Closed (duplicate) » Active
tadityar’s picture

tadityar CreditAttribution: tadityar commented

So, are we going to do all of them here or have separate issues like #2471655: Rename the Messages region in Seven. ? We need to close on of them

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Rename the default Messages region for all themes » [meta] Rename the default Messages region for all themes

This is the meta, child issues are:

But then we still need to update ThemeHandler and Classy. Child issues for those as well, or do we do those in this issue? Up to LewisNyman & emma.maria to decide :)

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented

Ahh hmm, originally this issue was just for Classy, which inherits the defaults regions. I was thinking this issue could handle the patch for Stark and Classy, which is effectively the default regions that affect all themes. I guess this can be a meta or just make the changes for the default regions.

jp.stacey’s picture

jp.stacey CreditAttribution: jp.stacey at Magnetic Phield commented
Status: Active » Closed (duplicate)

Rather than having a meta and child issues, I think we should handle this in one issue. Otherwise, how can we close any child issue, if the resulting patch from such an issue leaves HEAD inconsistent? It's a little bit messier to have it all in one, but patches are only coming out as three to five line changes anyway.

Given @alexpott has replied on #2470807: Rename the default "Messages" region for all themes to "Highlighted" regarding consistency, and given the patches on here don't reference "highlighted" so much as "informations", I nominate that one as having the historical record.