Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Apr 2015 at 10:43 UTC
Updated:
1 May 2015 at 16:44 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
JinX-Be commentedUpdated the help text
Comment #3
ifrikThanks JinX-Be,
it looks like you got two lines double at the end of your patch.
Comment #4
Reno Greenleaf commentedHere is the patch with double lines removed.
Comment #5
dimaro commentedChange status to Needs review to run test.
Comment #6
jhodgdonLooks pretty good! One thing to fix:
We don't normally say "a or b or c" in English. It should be "a, b, or c" instead if there are 3 choices.
This occurs twice in the patch.
Comment #7
joshi.rohit100Done as per #6.
Comment #8
Reno Greenleaf commentedThis last fix #7 looks good.

Comment #9
botrisThere where some missing comma's. It was A, B or C. But as we are using American English it should be A, B, or C.
Comment #10
ifrikThanks Boris Sondagh,
No more comma's missing.
Comment #11
jhodgdonNow there are too many commas.
In a list of 2, there should not be a comma.
So:
if you are using a or b, then do this. If you are using a, b, or c, do this.
Comment #12
botrisRemoved the commas in the lists of 2.
Comment #13
botrisComment #14
botrisand with interdiff...
Comment #15
ifrikThanks again,
now there is either no comma (a or b) or two commas (a, b, or c)
Comment #16
jhodgdonI would like to personally apologize for the strangeness of American English / Chicago Manual of Style punctuation rules, although I did not invent them. ;)
Thanks, looks good now!
Comment #17
webchickGreat, stuff, thanks! ;)
Committed and pushed to 8.0.x. Thanks!