Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
rest.module
Priority:
Critical
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
15 Apr 2015 at 09:10 UTC
Updated:
29 Apr 2015 at 17:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
klausiComment #2
klausiComment #3
klausiComment #4
pwolanin commentedI think this is critical, since changes to REST config will not appear in cached responses. Needs both the fix and tests
The simple fix from Wim & Berdir:
Comment #5
klausiThis is inconvenient, but a simple cache clear will solve the problem for users, so no need to call this critical.
Comment #6
pwolanin commentedLet's see if this breaks anything. still needs tests.
Comment #7
klausiGoing to work on a test case.
Comment #8
klausiklausi opened a new pull request for this issue.
Comment #9
klausiJust posting an intermediary patch here for Wim to see.
Comment #11
klausiklausi pushed some commits to the pull request.
For an interdiff please see the list of recent commits.
Comment #12
klausiFound the problem: we use a custom HTTP request method RESTTestBase, which does not have the $this->refreshVariables(); that drupalGet() does in the usual web tests. So the static cache of the cache tags invalidation service was never cleared, which means that the page cache entry for the response was never invalidated.
Comment #13
catchLooks like this is blocking #2364011: [meta] External caches mix up response formats on URLs where content negotiation is in use so bumping status back up to critical. Agreed it probably wouldn't be critical in its own right though.
Comment #14
pwolanin commentedLooks ok, but the wording of this comment is a little unclear:
So, the save doesn't clear the page cache per se as much as invalidating the cache tag and all caches that use it including the page cache.
Also we *now* not *still* get a cache miss? the last one was a hit.
Comment #15
klausiklausi pushed some commits to the pull request.
For an interdiff please see the list of recent commits.
Comment #16
klausiRight, that comment was outdated, fixed now.
Comment #17
klausiklausi pushed some commits to the pull request.
For an interdiff please see the list of recent commits.
Comment #18
klausiAnd while we are at it we should also add the entity cache tags.
Comment #19
pwolanin commentedLooks good. Entity cache tags is an important fix.
Comment #20
alexpottThis issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed bf9a2f3 and pushed to 8.0.x. Thanks!
Remove the unused use.
Comment #22
wim leersAwesome!
Comment #23
wim leers