OK, this is the final piece of #2299715: [meta] Move core hooks from system.api.php to core.api.php or other files

We have 4 core Token-related hooks that are currently in core/modules/system/system.api.php.

They should be moved into their own token.api.php file, which should follow the format of menu.api.php.

CommentFileSizeAuthor
#5 move_token_hooks_into-2470976-5.patch18.83 KBdimaro
#1 move-token-hooks-2470976-1.patch18.85 KBjeanfei

Comments

jeanfei’s picture

jeanfei commented
StatusFileSize
new move-token-hooks-2470976-1.patch18.85 KB

I've moved token hooks into token.api.php.

jeanfei’s picture

jeanfei commented
Status: Active » Needs review

forget to change the status.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Great, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: move-token-hooks-2470976-1.patch, failed testing.

dimaro’s picture

dimaro commented
Status: Needs work » Needs review
StatusFileSize
new move_token_hooks_into-2470976-5.patch18.83 KB

I moved the hooks again.
Locally applied, I hope it works.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • xjm committed fd66ee2 on 8.0.x 
    Issue #2470976 by jeanfei, dimaro, jhodgdon: Move token hooks into new...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +drupaldevdays

This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase.

+++ b/core/modules/system/system.api.php
@@ -5,10 +5,7 @@
-use Drupal\Core\Mail\MailFormatHelper;
...
-use Drupal\taxonomy\Entity\Vocabulary;

This is oh-so-slightly out of scope, but I'm okay with removing these two use statements here since they're unused and since we're changing a line next to them anyway.

Thanks @jeanfei and @dimaro, and thanks @jhodgdon for the review and signoff! Committed and pushed to 8.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.