Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
content_translation.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Apr 2015 at 15:24 UTC
Updated:
14 May 2015 at 11:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fran seva commentedComment #2
fran seva commentedComment #3
fran seva commentedComment #4
keopxComment #5
fran seva commentedComment #6
D Szkiba commentedI work on this on drupal dev days.
Comment #7
bogdan.racz commentedComment #8
bogdan.racz commentedComment #9
D Szkiba commentedComment #10
rodrigoaguileraSince this is a normal task is at risk for not being allowed to not be committed in the beta it needs a beta evaluation.
Comment #11
D Szkiba commentedMoved the function to path.module. However, this patch still contains the deprecated function getInternalPath so it's not finished yet.
Comment #12
rodrigoaguileraComment #13
rodrigoaguileraAdded more motivation for the change.
While writing it I realized that this is probably a bug since there might be situations where the path is not deleted when the translation is deleted. Any case that doesn't use the form.
We can also write tests for it deleting the translation using code instead of the form.
The code looks ok, only tests letft to do
Comment #14
rodrigoaguileraComment #15
D Szkiba commentedThis patch contains only the test.
Comment #16
D Szkiba commentedThere is still an error in the test, I'm just posting this to be able to test it with simpletest.
Comment #17
fran seva commentedComment #18
D Szkiba commentedThats (hopefully) the final version. "$this" was missing before assertFalse, thx fran for helping!
Comment #19
D Szkiba commentedComment #20
D Szkiba commentedComment #22
fran seva commentedThe code is good for me.
Comment #23
fran seva commentedComment #24
fran seva commentedComment #25
rodrigoaguileraCode looks great, thanks for working on it.
Comment #26
alexpottCommitted 612581d and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.
Added full stop for coding standards.
Comment #28
gábor hojtsyThanks!