After an upgrade to Views 6.x-2.18, addressing PHP 5.4x compatibility, the views_attach module is issuing warning:

strict warning: Declaration of views_attach_plugin_display_node_content::options_submit() should be compatible with views_plugin_display::options_submit(&$form, &$form_state) in sites/all/modules/views_attach/views_attach_plugin_display_node_content.inc on line 248.

I am assuming this is a PHP 5.4x compatibility issue here as well?
Ref: strict warnings with PHP 5.4.x

CommentFileSizeAuthor
#5 2470141-views_attach-strict-05.patch1.53 KBgaurav.kapoor
#1 2470141-views_attach-strict-01.patch1.14 KBmicahw156

Comments

micahw156’s picture

micahw156
he/him/his
commented
Version: 6.x-2.2 » 6.x-2.x-dev
Priority: Critical » Major
Status: Active » Needs review
StatusFileSize
new 2470141-views_attach-strict-01.patch1.14 KB

I think the attached patch is all that is needed to resolve this. At least it made my errors go away.

Downgrading from critical to major because this generates warnings but does not break the site.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community
ghazlewood’s picture

ghazlewood
Location Hampshire, UK
commented

Worked for me...

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Related issues: +#2411093: PHP strict warnings: Declaration of ... should be compatible with ...

See also #2411093: PHP strict warnings: Declaration of ... should be compatible with ...

gaurav.kapoor’s picture

gaurav.kapoor commented
StatusFileSize
new 2470141-views_attach-strict-05.patch1.53 KB

Thanks for the patch and review.Added appropriate comments.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.