Problem/Motivation

Two problems with that.

a) It causes a weird shutdown curl segfault in PHP 7.
b) It's a very unreliably test anyway. It relies on a assertNoRaw() instead of actually looking for a message that is there to make sure that the password works. All it takes is we change the text we display there and it would be bogus.

Proposed resolution

Use the API to check the password. I also don't really get the comment, how exactly are we testing that it was re-hashed and salted? We just check that it works?

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 migrate-php7-segfault-user-curl-2469269-1.patch1.14 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new migrate-php7-segfault-user-curl-2469269-1.patch1.14 KB

Here's a patch. It's much easier like this IMHO :)

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

I guess. At the end of the day, the only way to actually test migrate would be to rerun every test based on the migrated database and since that's hopeless let's not even try and hope that the API surface testing is enough. That should be enough indeed. We do not, after all, test mostly through the browser in most cases. So yeah. Let's not do this here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Yep this looks way less fragile, the assertNoRaw looks very dodgy. Committed 60d4bd8 and pushed to 8.0.x. Thanks!

  • alexpott committed 60d4bd8 on 8.0.x 
    Issue #2469269 by Berdir: Don't use a form submission to check the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.