\Drupal\Component\Annotation\Plugin\Discovery\AnnotatedClassDiscovery contains outdated code comments that imply definitions are always arrays. Next to that there are some minor improvements that can be made to make the file comply with our current documentation standards.

CommentFileSizeAuthor
#1 drupal_2468901_1.patch2.2 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Active » Needs review
FileSize
drupal_2468901_1.patch2.2 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2468901_1.patch, failed testing.

Status: Needs work » Needs review

Xano queued 1: drupal_2468901_1.patch for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 2388e34 and pushed to 8.0.x. Thanks!

  • alexpott committed 2388e34 on 8.0.x 
    Issue #2468901 by Xano: Improve \Drupal\Component\Annotation\Plugin\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.