Targeting img element is rather presumpuous. This patch just makes it set defaults to panopoly img tags.

This is to http://drupal.org/project/panopoly_images , and I'm uploading the patch to http://drupal.org/project/panopoly .

CommentFileSizeAuthor
#10 2468445.patch689 bytesrobloach
#2 panopoly_images-img-css-2468445-2.patch519 bytesdsnopek
panopoly-images.patch431 bytesrobloach

Comments

robloach’s picture

robloach
he/him
commented
Issue summary: View changes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_images-img-css-2468445-2.patch519 bytes

Ah, good catch, thanks! Only the theme should mess with all 'img' tags. However, you missed a few of the image styles from Panopoly. Here's a new patch with the rest. It looks good in my testing! I'll commit in a moment.

  • dsnopek committed 5bf16b1 on 7.x-1.x 
    Update Panopoly Images for Issue #2468445 by RobLoach, dsnopek: Panopoly...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Committed! Thanks, again. :-)

  • dsnopek committed 1e8b10a on 7.x-1.x 
    Revert "Update Panopoly Images for Issue #2468445 by RobLoach, dsnopek:...
  • dsnopek committed 5a229dd on 7.x-1.x
    Update Panopoly Images for Issue #2468445 by RobLoach, dsnopek: Panopoly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andrew_mallis’s picture

andrew_mallis commented
Status: Closed (fixed) » Needs work

There is a regression when using the media browser library to search for items of type video.

.media-thumbnail {
  width: 80px;
  height: 80px;
}

should include

.media-thumbnail {
  width: 80px;
  height: 80px;
  max-width: 100%;
  width: 100%;
  float: none;
}

or the video thumbnails bust outside their container.

It's kinda late rolling a proper patch is outside my immediate reach. Maybe tomorrow.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks! If you do roll a patch, can you put it on a new issue?

robloach’s picture

robloach
he/him
commented

Should those style definitions be part of the Media module? Looks like there isn't a `.media-thumbnail` definition in media.css.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 2468445.patch689 bytes

Ah, I see it part of panopoly_images....

https://github.com/RobLoach/panopoly_images/pull/1
https://github.com/RobLoach/panopoly_images/pull/1.diff
https://github.com/RobLoach/panopoly_images/pull/1.patch

git remote add robloach git@github.com:RobLoach/panopoly_images.git
git fetch --all
git pull robloach 2468445
git push origin 7.x-1.x
andrew_mallis’s picture

andrew_mallis commented

I've taken a closer look at this and have a better solution in mind. Will post new issue.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

https://www.drupal.org/node/2573877

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.