I am not sure, but looking at the code I suspect this module has the same issue with Drupal 7.36 that other Filefield Sources-related modules have (see https://www.drupal.org/drupal-7.36-release-notes).

Comments

David_Rothstein’s picture

Status: Active » Needs review
StatusFileSize
new610 bytes

Here is an (untested) patch based on the fix that works for the other modules.

deggertsen’s picture

I haven't run into this problem yet myself, but I'll watch for it.

deggertsen’s picture

Status: Needs review » Reviewed & tested by the community

Yes, this patch fixes an issue introduced as described above. Marking as RTBC.

deggertsen’s picture

Status: Reviewed & tested by the community » Fixed

Committed

torgospizza’s picture

Thanks for taking care of this! I've just been too busy to look at anything else lately :)

deggertsen’s picture

The only thing I debated with this one is making it a requirement or something that you have D7 7.36 or greater. I think this patch will break it if you have an earlier version of D7. However, I doubt that most people installing the module at this point will have an earlier version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

The only thing I debated with this one is making it a requirement or something that you have D7 7.36 or greater. I think this patch will break it if you have an earlier version of D7.

The way the patch is written, it's intended to work on Drupal 7.35 and earlier also. I didn't test it there though.

Note that this could become relevant again in the future since #2594955: [D7] Duplicate HTML IDs are created for file_managed_file fields may need to roll back some of the code that was added in 7.36.