Change $info array argument to system_get_module_admin_tasks() to $name

I committed #2281989: Add a fast and simple way to get module name from the module handler, so this is no longer postponed.

What about leaving the function, but removing the 2nd parameter ($info)? Looks to me like the only thing that parameter is used for is for the human-readable name, and can't the function ask the module handler for that instead of requiring it as a parameter? I think it would solve the goal of the issue to remove the system_get_info() calls, and the only BC it would break is if there's some contrib caller calling it with a different human-readable name than the module's real one, which I think is enough of an edge case to be ok breaking.

Awesome. Thanks.

Is the idea that system_get_info() calls add performance overhead? Can we add a beta evaluation please since this is a normal task?

As per last comment from @stefan.r, looks like this issue needs a decision before work.

We probably eventually want to get rid of system_get_info() and this helps toward that, as there is no reason for this function to need all of the module info.

I am removing the novice tag, since it no longer follows the pointers on https://www.drupal.org/core-mentoring/novice-tasks.

Agreed, thanks @piyuesh23.

Since this is an API change, we now should deprecate the argument instead of removing it. I agree with the longterm goal of removing system_get_info() in general, but I think that is out of scope here. We can probably go ahead with this for the next development minor if we can do it in a BC way.

Now that #2208429: Extension System, Part III: ExtensionList, ModuleExtensionList and ProfileExtensionList is in, this can be completed if still necessary, or it could be added to the scope of #2940189: Deprecate system_get_info()

re-roll for 10.1

valid patch

random failure

Can the issue summary proposed solution be updated please.

Also this appears to just be removing vs deprecating. Any concern with breaking a contrib module?

I think we can add deprecation but it's can be caught with phpstan - something pass more then one argument to function that expects only one)

Here's a patch to narrow down API to expected information only (human readable module name)

It will help of we'll change resulting array to some value object

+++ b/core/modules/system/system.module
@@ -972,14 +972,11 @@ function system_admin_compact_mode() {
-function system_get_module_admin_tasks($module, array $info) {
+function system_get_module_admin_tasks($module) {

@@ -1026,7 +1023,7 @@ function system_get_module_admin_tasks($module, array $info) {
-        'title' => t('Configure @module permissions', ['@module' => $info['name']]),
+        'title' => t('Configure @module permissions', ['@module' => \Drupal::service('extension.list.module')->getName($module)]),

as it consumes a string and we gonna formalize extension info structure it makes sense to change type to array|string

And there's just a few usages in contrib

Fix typo

If the issue summary could be updated also please.

@andypost looking at "Use to pass only $info["name"] instead" that doesn't read right to me. What about just "Pass only $info["name"]"

Thanks, fixed and added deprecation test

Thanks!

Random failure

Fixed this typo on commit:

diff --git a/core/modules/system/system.module b/core/modules/system/system.module
index 5f79fca5b8..9a0926a9a9 100644
--- a/core/modules/system/system.module
+++ b/core/modules/system/system.module
@@ -983,7 +983,7 @@ function system_admin_compact_mode() {
  */
 function system_get_module_admin_tasks($module, string|array $module_name) {
   if (!is_string($module_name)) {
-    @trigger_error('Calling ' . __FUNCTION__ . '() with $module_name argument as array is deprecated in drupal:10.2.0 and is required to be staring from drupal:11.0.0. Pass only $info["name"] instead. See https://www.drupal.org/node/3357711', E_USER_DEPRECATED);
+    @trigger_error('Calling ' . __FUNCTION__ . '() with $module_name argument as array is deprecated in drupal:10.2.0 and is required to be string from drupal:11.0.0. Pass only $info["name"] instead. See https://www.drupal.org/node/3357711', E_USER_DEPRECATED);
     $module_name = $module_name['name'];
   }
 

Committed/pushed to 10.2.x, thanks!

This is only used in two places in core - AdminController in system module and HelpController in help module. I think we could make it a trait in system module to get it out of .module altogether? Tagging for a follow-up. Since this issue is already eight years old I didn't want to derail it by proposing that for here.

Thank you!

Follow-up already exists #3038971: Move system_get_module_admin_tasks() into a service and deprecate it

Published the CR