XML writing is being used by the Drupalci project. It's currently broken :(

Running run-tests.sh with the following options --xml ~/xml --class 'Drupal\hal\Tests\DenormalizeTest' results in the following failure:

PHP Warning:  file_put_contents(/Users/alex/al.xml/Drupal\hal\Tests\DenormalizeTest.xml): failed to open stream: No such file or directory in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/scripts/run-tests.sh on line 1006
CommentFileSizeAuthor
#2 2465611.1.patch1.24 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2465611.1.patch1.24 KB
amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Assuming that DrupalCI doesn't need to map the file name back to a class name (i.e. it just loads all the xml files for a test run), the fix looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 74c98d3 on 8.0.x 
    Issue #2465611 by alexpott: Fix --xml option in run-tests.sh
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

FYI: I guess this only actually failed on osx, it didn't have a problem to create those files on linux. But the file names were annoying there as well and various tools then didn't work, so the fix makes sense.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Really? That's bit weird because I was inside a ubuntu vm when I got these errors.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No idea, but I've been using --xml for http://d8ms.worldempire.ch/ and it worked for me. But I wanted to suggest this as a change anyway, so totally +1. Also, /Users/alex/al.xml

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

re #8 and /Users/alex/al.xml - yeah that was when I didn't point --xml to a directory.

There were more problems with the drupalci --xml option - fixed in https://github.com/drupalci/drupalci_testbot/pull/6

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The PR turned out to be the wrong way to contribute - see #2465435-10: Various errors encountered when trying to get things up and running

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.