Problem/Motivation

Vocabulary listing is showing add new vocabulary link under 'Add terms' text instead of add taxonomy term link in operations links.

Proposed resolution

Correct add taxonomy term link on vocabulary listing.

Remaining tasks

  1. Review
  2. RTBC
  3. Commit

User interface changes

It will fix the add taxonomy term link in operations links on vocabulary listing.

API changes

None.

Suggested commit message

git commit -m 'Issue #2465425 by jibran, pjonckiere, idebr: Vocabulary listing missing add taxonomy term link'

CommentFileSizeAuthor
#5 Screenshot from 2015-04-04 17:40:39.png37.31 KBjibran
vocab-list-missing-link.patch1.75 KBjibran
vocab-list-missing-link-test-only.patch907 bytesjibran

Comments

The last submitted patch, vocab-list-missing-link-test-only.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented

This is a duplicate of #2409079: "Add term" buttons on vocabulary overview link to "Add vocabulary" form. However, the patch in this issue is way better so I'd keep this one.

Shivam Agarwal’s picture

Shivam Agarwal commented

@jibran I tried to review this patch. Patch applied cleanly but can you attach the screenshot of interface which has changed so that I can crosscheck with mine. I can't figure out where these changes are applied actually.

Shivam Agarwal’s picture

Shivam Agarwal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png74.32 KB
new after_patch.png77.53 KB

I think I have found the change. Please find attached screenshot of interface before and after applying patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
StatusFileSize
new Screenshot from 2015-04-04 17:40:39.png37.31 KB

Thanks @pjonckiere I did look up in taxonomy issue queue sorry I missed the issue. I'll add suggested commit message to this issue and will close #2409079: "Add term" buttons on vocabulary overview link to "Add vocabulary" form one as duplicate.
Thanks @Shivam Agarwal for testing this. Here are the steps to check the patch is working fine or not.

  1. To test go to admin/structure/taxonomy.
  2. Click the operations dropdown in front of Tags vocabulary.
  3. Click on the Add terms link.
  4. Before the patch it was pointing to admin/structure/taxonomy/add.
  5. After the patch it is pointing to admin/structure/taxonomy/manage/tags/add.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes

Thanks @Shivam Agarwal for the review.

Shivam Agarwal’s picture

Shivam Agarwal commented

@jibran +1 to you :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Can't think of a useful way to automated test this, so...

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a9b27b5 on 8.0.x 
    Issue #2465425 by jibran, pjonckiere, idebr: Vocabulary listing missing...
Shivam Agarwal’s picture

Shivam Agarwal commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.