Problem/Motivation

It makes zero sense for the UUID field to be click sortable, we turn this off for other fields that this doesn't makes sense.

Proposed resolution

Disable click sorting for UUID fields.

Remaining tasks

Patch/reviews

User interface changes

Will not be able to use uuid as a sortable column when editing a view, or when using a view using sorting.

API changes

CommentFileSizeAuthor
#2 interdiff-2465031-2.txt847 bytesdamiankloip
#2 2465031-2.patch1.88 KBdamiankloip
vdc-disable-uuid-sorting.patch1.89 KBdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented

Great idea!!

+++ b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php
@@ -766,6 +766,7 @@ protected function assertLongTextField($data, $field_name) {
+    $this->assertEquals(FALSE, $data['field']['click sortable']);

What about using $this->assertFalse?

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2465031-2.patch1.88 KB
new interdiff-2465031-2.txt847 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 0a0e884 and pushed to 8.0.x. Thanks!

  • alexpott committed 0a0e884 on 8.0.x 
    Issue #2465031 by damiankloip: Do not allow UUID field to be click...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.