I noticed these in the temporary SQLite testbot and then again in @Berdir's test results from #2454439-26: [META] Support PHP 7.

Let's fix them.

CommentFileSizeAuthor
#4 2464817-4.patch3.25 KBamateescu
#2 2464817-fix-simpletest-script-cleanup.patch532 bytesamateescu
#1 2464817.patch2.49 KBamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2464817.patch2.49 KB

And a patch.

amateescu’s picture

amateescu commented
StatusFileSize
new 2464817-fix-simpletest-script-cleanup.patch532 bytes

We might also want to do something like this, but then we'll lose the ability to easily see which phpunit test is not in the correct namespace :/

The last submitted patch, 1: 2464817.patch, failed testing.

amateescu’s picture

amateescu commented
StatusFileSize
new 2464817-4.patch3.25 KB

Fixed the patch from #1. Are there any opinions on #2?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

I think we should fix them either way, so let's commit #4.

If we want to enforce that unit tests are in \Drupal\Tests (and I think we want), then I think we should do it explicitly and find a way to make them fail, not just display a confusing error that isn't detected by the testing system :)

Verified that the error is gone and that those 4 are all those tests.

There's a 5th in my test results, but that one is really broken and a different problem( no apcu)

stefan.r’s picture

stefan.r commented

Created follow up over at #2465029: Ensure that PHPUnit tests are in the correct namespace

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thanks for filing the followup. Committed a5b11cc and pushed to 8.0.x. Thanks!

  • alexpott committed a5b11cc on 8.0.x 
    Issue #2464817 by amateescu: A few PHPUnit tests are not in the correct...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.