Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I noticed these in the temporary SQLite testbot and then again in @Berdir's test results from #2454439-26: [META] Support PHP 7.
Let's fix them.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2464817-4.patch | 3.25 KB | amateescu |
| #2 | 2464817-fix-simpletest-script-cleanup.patch | 532 bytes | amateescu |
| #1 | 2464817.patch | 2.49 KB | amateescu |
Comments
Comment #1
amateescu commentedAnd a patch.
Comment #2
amateescu commentedWe might also want to do something like this, but then we'll lose the ability to easily see which phpunit test is not in the correct namespace :/
Comment #4
amateescu commentedFixed the patch from #1. Are there any opinions on #2?
Comment #5
berdirI think we should fix them either way, so let's commit #4.
If we want to enforce that unit tests are in \Drupal\Tests (and I think we want), then I think we should do it explicitly and find a way to make them fail, not just display a confusing error that isn't detected by the testing system :)
Verified that the error is gone and that those 4 are all those tests.
There's a 5th in my test results, but that one is really broken and a different problem( no apcu)
Comment #6
stefan.r commentedCreated follow up over at #2465029: Ensure that PHPUnit tests are in the correct namespace
Comment #7
alexpottThanks for filing the followup. Committed a5b11cc and pushed to 8.0.x. Thanks!