This issue is part of #2454513: [meta] Make Drupal 8 work with SQLite

Drupal\system\Tests\Entity\FieldSqlStorageTest is failing because SQLite has some very relaxed rules for data types, so defining a table column as VARCHAR(-1) works :/

CommentFileSizeAuthor
#1 2463103.patch1022 bytesamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2463103.patch1022 bytes

This is a nice trick that generates an invalid sql syntax even on SQLite.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Discussed with @amateescu in IRC. This test is a bit odd but this makes in fail in all three supported dbs.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Let's dooo eeeet!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 9d92bf8 on 
    Issue #2463103 by amateescu: SQLite: Fix system\Tests\Entity\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.