In #2449371: Link to container raw data we introduced a raw data view alongside the structured view. In #2451161: Standardise property output and make custom build() optional we are adding a table of values. They are currently placed below each other in foldable details elements, which can be clunky to use.
Use tabs. Local tasks is a start, but ideally we would have the tab row in direct connection to the data display. There is no pattern like that in Core so I'm not sure how to do it.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | use_tabs_for_switching-2462945-11.interdiff.txt | 1.57 KB | arla |
| #10 | use_tabs_for_switching-2462945-10-interdiff.txt | 1.04 KB | mbovan |
| #10 | use_tabs_for_switching-2462945-10.patch | 14.46 KB | mbovan |
| #8 | use_tabs_for_switching-2462945-8.patch | 14.45 KB | mbovan |
| #4 | use_tabs_for_switching-2462945-4-interdiff.txt | 610 bytes | mbovan |
Comments
Comment #1
mbovan commentedDiscussed with @miro_dietiker and @Berdir. Here is the current proposal (screenshots only).
Container view, in case there is no plugin applied. Raw data tab is added.
Raw data page looks like:
In case the plugin is applied, list of properties is displayed.
In case the plugin is applied and it has specialized display, the container view looks like:
Comment #2
mbovan commentedHere is the patch with the changes from screenshots. Updated tests.
Also added a message in case there is no plugin configured.
Comment #4
mbovan commentedNo errors locally.
I guess, I need to call
$container->urlInfo()->setAbsolute(TRUE)instead$container->url().The problem is when Drupal is installed in subdirectory (like Testbot).
url()returns the base directory (in this case/checkout) which is then added twice indrupalGet().Comment #5
arla commentedScreenshots look nice.
If the plugin has specialized display, will we want to see also the default output, i.e. the list of property values? If so, should that be another tab?
Comment #8
mbovan commentedRerolled.
@Arla: There would be a problem that default output is displayed "twice" (on the tab "Default display" page and container view page for the entities that don't have specialized display), except we deal with
customAccessCheck()for local tasks or something similar...Comment #10
mbovan commentedFixed some mistakenly rebased lines.
Comment #12
arla commentedFixed some comment cruft on commit (see interdiff). Committed and pushed!