As per #2459971: The langcode key on configuration files is not explicit in configuration schema.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because removing deprecated code
Issue priority Normal because nothing is broken
Prioritized changes The main goal of this issue is as followup from several critical and major issues to resolve problems with multi-lingual config installation. They added and then, in turn, deprecated the parameter. See #2212069: Non-English Drupal sites get default configuration in English, edited in English, originals not actually used if translated and #2459971: The langcode key on configuration files is not explicit in configuration schema
Disruption None. The parameter has not been around long enough for contrib to rely on it.
Files: 
CommentFileSizeAuthor
#1 remove-2462889-1.patch2.47 KBtim.plunkett
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 92,119 pass(es). View

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
2.47 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 92,119 pass(es). View
alexpott’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The removal looks good. And I added the beta eval.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: remove-2462889-1.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: remove-2462889-1.patch, failed testing.

The last submitted patch, 1: remove-2462889-1.patch, failed testing.

Gábor Hojtsy’s picture

Issue tags: +sprint

The tail of the test output looks like

Drupal\simpletest\Tests\KernelTestBaseTest                    92 passes
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated
Terminated].

That looks unrelated.

Status: Needs work » Needs review
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: remove-2462889-1.patch, failed testing.

Gábor Hojtsy’s picture

Several unrelated fails again:

Could not open input file: ./core/scripts/run-tests.sh
FATAL Drupal\aggregator\Tests\FeedParserTest: test runner returned a non-zero error code (255).
FATAL Drupal\system\Tests\Ajax\MultiFormTest: test runner returned a non-zero error code (1).
FATAL Drupal\ban\Tests\IpAddressBlockingTest: test runner returned a non-zero error code (1).
FATAL Drupal\basic_auth\Tests\Authentication\BasicAuthTest: test runner returned a non-zero error code (1).
FATAL Drupal\system\Tests\Batch\PageTest: test runner returned a non-zero error code (1).
FATAL Drupal\system\Tests\Batch\ProcessingTest: test runner returned a non-zero error code (1).
FATAL Drupal\system\Tests\Block\SystemMenuBlockTest: test runner returned a non-zero error code (1).
FATAL Drupal\block\Tests\BlockAdminThemeTest: test runner returned a non-zero error code (1).
FATAL Drupal\block\Tests\BlockCacheTest: test runner returned a non-zero error code (1).

Status: Needs work » Needs review
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 9378097 on 8.0.x
    Issue #2462889 by tim.plunkett: Remove TypedConfigManagerInterface::...
Gábor Hojtsy’s picture

Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.