Follow-up to #2363741: Upgrade Twig to 1.16.* from 1.15.*

Follow-up to #2172235: Upgrade Twig to 1.15.* from 1.12.*

Problem/Motivation

Change Log Diff:

* 1.18.0 (2015-01-25)
* fixed some error messages where the line was wrong (unknown variables or argument names)
* added a new way to customize the main Module node (via empty nodes)
* added Twig_Environment::createTemplate() to create a template from a string
* added a profiler
* fixed filesystem loader cache when different file paths are used for the same template

* 1.17.0 (2015-01-14)
* added a 'filename' autoescaping strategy, which dynamically chooses the
autoescaping strategy for a template based on template file extension.

* 1.16.3 (2014-12-25)
* fixed regression for dynamic parent templates
* fixed cache management with statcache
* fixed a regression in the slice filter

Proposed resolution

Update Twig to 1.18.* from 1.16.*

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Files: 
CommentFileSizeAuthor
#8 2462393-8.patch80.26 KBstefan.r
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,695 pass(es). View
#2 2462393-2.patch181.72 KBstefan.r
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,480 pass(es). View

Comments

stefan.r’s picture

Issue summary: View changes
Issue tags: -security, -Perfomance
Parent issue: #2363741: Upgrade Twig to 1.16.* from 1.15.* »
stefan.r’s picture

Status: Closed (fixed) » Needs review
FileSize
181.72 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,480 pass(es). View
joelpittet’s picture

I was thinking of this for a while but was waiting on a 1.18.1 because it looked like there were a few mor things coming on that one.

Is there urgency from any of those fixes Stefan?

joelpittet’s picture

Cottser’s picture

Status: Needs review » Closed (duplicate)

Sorry @stefan.r, #2472961: Update Twig to latest stable got in really quick!

joelpittet’s picture

Title: Upgrade Twig to 1.18.* from 1.16.* » Upgrade Twig to 1.18.1 from 1.18.0
Status: Closed (duplicate) » Postponed

Let's leave this open for Stefan.r's commit cred and bump it for that .18.1 fixes as I mentioned above in #4

Setting as postponed.

I'll check to see when that release is expected in the upstream queue.

Cottser’s picture

Status: Postponed » Active
stefan.r’s picture

Status: Active » Needs review
FileSize
80.26 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,695 pass(es). View

:)

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

That was quicker than I expected. https://github.com/twigphp/Twig/issues/1672

Thanks @stefan.r

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Wow, now that's service! ;)

Changes are isolated to /core/vendor. Just a minor point release change, so...

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 517b44d on 8.0.x
    Issue #2462393 by stefan.r, joelpittet: Upgrade Twig to 1.18.1 from 1.18...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.