Problem/Motivation

Libraries in core that are not the latest stable release of the library need to be updated prior to the release of 8.0.0, as per #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0

Proposed resolution

Update the picturefill library to the latest stable release: 2.3.0 (23rd March 2015).

Remaining tasks

  • Replace the picturefill.min.js library file in /core/assets/vendor/picturefill.min.s/ with the 2.3.0 release from GitHub repo
  • Perform manual testing

User interface changes

None

API changes

None

CommentFileSizeAuthor
#5 picturefill230-2462261-05.patch14.88 KBnicrodgers
#2 picturefill230-2462261-02.patch14.88 KBnicrodgers

Comments

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Issue summary: View changes

updated issue summary

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
StatusFileSize
new picturefill230-2462261-02.patch14.88 KB

Added patch

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: picturefill230-2462261-02.patch, failed testing.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
StatusFileSize
new picturefill230-2462261-05.patch14.88 KB

Uploading corrected patch

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Needs work » Needs review
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Parent issue: » #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0
Anonymous’s picture

Anonymous (not verified) commented 
+++ b/core/assets/vendor/picturefill/picturefill.min.js
@@ -1,4 +1,4 @@
\ No newline at end of file

This should be removed from the patch.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Needs review

Third party files (anything in core/assets/vendor) don't need to follow are standards.

stefan.r’s picture

stefan.r commented
Status: Needs review » Reviewed & tested by the community

Did an interdiff with my own patch over at #2463611: Upgrade picturefill from 2.2.1 to 2.3.0 and found no changes.

I shall be closing the other issue as a duplicate.

stefan.r’s picture

stefan.r commented

Also, this:

I think 2.2.1 was short-lived as 2.3.0 was scheduled for an imminent release. I've created two pull requests to update the site to reflect that 2.3.0 is the recommended stable version.

2.3.0 fixes a range of bugs and has some performance improvements, as well as adding support for newer image formats, intrinsic image dimensions, and commonJS exports. More details here: https://github.com/scottjehl/picturefill/releases

Basically, we heartily recommend you upgrade to 2.3.0. It's the bee's knees.

https://github.com/scottjehl/picturefill/issues/474#issuecomment-88410346

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

I'd like @attiks or @Jelle_S to RTBC this. They know best what to manually test.

droplet’s picture

droplet commented

I am curious of what manual test is needed. @attiks or @Jelle_S please tell us when you do reviews :)

stefan.r’s picture

stefan.r commented

Sorry, got this issue mixed up, thought this had already been RTBC'ed previously.

attiks’s picture

attiks commented

I'll test it now on simplytest.me, make sure to use a browser without picture support if you test it.

attiks’s picture

attiks commented
Status: Needs review » Reviewed & tested by the community

Tested on simplytest.me using chrome and firefox and it works like it should

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a9c270f on 8.0.x 
    Issue #2462261 by nicrodgers, stefan.r, attiks: Update picturefill to 2....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.