Problem/Motivation

Libraries in core that are not the latest stable release of the library need to be updated prior to the release of 8.0.0, as per #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0

Proposed resolution

Update the underscore library to the latest production release: 1.8.3 (April 2, 2015).

Remaining tasks

  • Replace the underscore-min.js library file in /core/assets/vendor/underscore/ with the 1.8.3 release from http://underscorejs.org/
  • Update core.libraries.yml
  • Perform manual testing

User interface changes

None

API changes

None

CommentFileSizeAuthor
#9 underscore183-2462259-9.patch32.04 KBstefan.r
#7 underscore183-2462259-7.patch32.04 KBstefan.r
#3 underscore182-2462259-03.patch32.11 KBnicrodgers

Comments

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Parent issue: » #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Issue summary: View changes

updated issue summary

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Active » Needs review
StatusFileSize
new underscore182-2462259-03.patch32.11 KB

uploading patch

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work 
  1. +++ b/core/assets/vendor/underscore/underscore-min.js
@@ -1,6 +1,6 @@
+//     (c) 2009-2015 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors

    Comments should not be longer than 80 chars. While I know this is a little out of scope here, I think we could fix it here. 

  2. +++ b/core/assets/vendor/underscore/underscore-min.js
@@ -1,6 +1,6 @@
\ No newline at end of file

    This will have to go.

nod_’s picture

nod_
Primary language French
Location Lille
commented

while this is true, This file is a third party lib, they don't follow our standards. We just take them as-is.

Letting as NW because quickedit has a problem now. After editing a field, quickedit can't be closed.

kevin morse’s picture

kevin morse commented
Title: Update underscore to 1.8.2 » Update underscore to 1.8.3
Issue summary: View changes

Underscore is now at 1.8.3

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
StatusFileSize
new underscore183-2462259-7.patch32.04 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work

Wrong version in libraries.yml

quickedit works again.

stefan.r’s picture

stefan.r commented
StatusFileSize
new underscore183-2462259-9.patch32.04 KB

Nice!

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Quickedit, text filter admin, toolbar, tour, contextual, ckeditor admin.

Everything depending on underscore/backbone is still working.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Per #11, RTBC+1

  • webchick committed d840205 on 8.0.x 
    Issue #2462259 by stefan.r, nicrodgers, nod_: Update underscore to 1.8.3
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Perfect, thanks for the manual testing.

Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.