Blocks #606840: Enable internal page cache by default.

This fixes the 3 failures o/t parent issue in:

  • Drupal\system\Tests\Theme\TwigRegistryLoaderTest (6)
CommentFileSizeAuthor
#7 2461097-7.patch751 byteswim leers
#1 2461097-1.patch834 byteswim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2461097-1.patch834 bytes
star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Twig

Looks good, removing the part about search pages from the issue summary, guessing that isn't meant for this issue.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#2: thanks for the IS fix, c/p remnant :)

fabianx’s picture

fabianx commented

RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Postponed
Related issues: +#2461087: Add 'no_cache' route option to mark a route's responses as uncacheable (was: Cron run response should not be cacheable)

Postponing on #2461087: Add 'no_cache' route option to mark a route's responses as uncacheable (was: Cron run response should not be cacheable) which is going to add a better way to do this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Make TwigThemeTestController:::registryLoaderRender()'s response uncacheable » [PP-1] Make TwigThemeTestController:::registryLoaderRender()'s response uncacheable
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Make TwigThemeTestController:::registryLoaderRender()'s response uncacheable » Make TwigThemeTestController:::registryLoaderRender()'s response uncacheable
Status: Postponed » Needs review
Issue tags: +Quickfix
StatusFileSize
new 2461097-7.patch751 bytes

#2461087: Add 'no_cache' route option to mark a route's responses as uncacheable (was: Cron run response should not be cacheable) landed, this is now unblocked. Rerolled using the new, superior technique introduced there.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, what should I say :).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3f4564b and pushed to 8.0.x. Thanks!

  • alexpott committed 3f4564b on 8.0.x 
    Issue #2461097 by Wim Leers: Make TwigThemeTestController:::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.