Major clean-up and re-factor patch [#2460577]

Attached is a patch that majorly re-factors this module, as follows:

Corrects the name of the module and adds a description in the info file.
Removes the separate "user picture field" configuration screen and places all of the settings for the module under "Account settings" where all of the standard user picture settings live.
Replaces the bundle and field text fields with drop-downs that automatically refresh via AJAX when the entity type or bundle drop-downs change value, preventing typos when entering bundle and field names. Only "image" fields are available for selection.
Hides user picture field settings when user picture support is not enabled.
Hides most of Drupal core's picture settings when user picture field support is turned on, and vice-versa.
Splits-out Profile2 specific code into its own file, which is also distinct from the logic that deals with fields in the user account.

This should greatly improve the usability of the configuration form for the module.

Comment	File	Size	Author
#2	user_picture_field-refactor_multiple_areas-2460577-2-7.x.patch	24.76 KB	GuyPaddock
#1	user_picture_field-refactor_multiple_areas-2460577-1-7.x.patch	24.76 KB	GuyPaddock

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

File	Size
user_picture_field-refactor_multiple_areas-2460577-1-7.x.patch	24.76 KB

File	Size
user_picture_field-refactor_multiple_areas-2460577-2-7.x.patch	24.76 KB

File	Size
user_picture_field-refactor_multiple_areas-2460577-1-7.x.patch	24.76 KB

Comment #3

g089h515r806 CreditAttribution: g089h515r806 commented 27 March 2015 at 13:53

It is a big patch, I think it will be better if we create a 7.x-2.x branch and you commit your code to this branch.
I could add you to maintainer of this project.

Comment #4

GuyPaddock CreditAttribution: GuyPaddock commented 28 March 2015 at 13:56

That works too! The patch is API and data compatible with what's there, it really just cleans-up the UI.

Comment #5

System Lord CreditAttribution: System Lord commented 21 May 2015 at 22:20

I like this patch. It all makes better sense. Thank you for the effort!

I do have an issue, though, and I'm not sure where to list it. I'm using a Profile2 field for images and it works. However, I need a default image in place until my users upload their own. The Profile2 image field allows for default image (since this module/patch removes the default_image option from admin account settings) and it does displayed in profile view, but it wont display in Private message lists/threads. It's just empty.

The strange part is is when a user actually uploads their own image everything works/looks fine and if they remove their own image (which then causes the default image to be used again) the default image suddenly appears in PM.

Any thoughts?

Comment #6

GuyPaddock CreditAttribution: GuyPaddock commented 21 May 2015 at 22:51

Assigned:	Unassigned	» GuyPaddock
Status:	Needs review	» Needs work

Great timing!

I'm actually working on better default image handling. We're seeing some similarly strange behavior in our sites, and with the patch it's hard to set the default image since it's not based on the default image for the profile field and the default image field gets hidden in account settings when you toggle to use a field.

Comment #7

System Lord CreditAttribution: System Lord commented 21 May 2015 at 23:13

Sweet! I stand ready for any assistance I can provide. (probably just testing. I don't know php.)

Comment #8

System Lord CreditAttribution: System Lord commented 26 May 2015 at 05:53

Seeing another related issue to this module or patch. If I have a dozen messages in my list and I preform any action Delete, Mark as read, or Mark as unread, all user pictures disappear with their username put in its place. When I refresh the page all the pictures return.

UPDATE: Sorry, wrong place. Moved to: https://www.drupal.org/node/2402063#comment-9959481