Hi,
Thank you for the wonderful module.
We are using lazyloader on one of our site. Issue that we are facing is that Lazyloading does not work when the next set of slides appear in the visible are of the browser on click of the navigation arrows. But Images laod as soon as I scroll.
On debugging I found out that Lazyload function is bind to the SCROLL event.
Seeking help here so that module works with flexslider and this function (lazylaod )is called also on the click of Navigation items.
Patch would be appreciated.

CommentFileSizeAuthor
#3 lazyloader_does_not-2458981-3.patch416 bytesneetu morwani

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

This is related to #1989816: Support fof Views Sideshow or any other slideshow?. I'm suspending this issue until the release of the next stable version (1.4) after which I will start work on the 2.x branch where I'll work on integration with other modules (amongst other things).

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Active » Postponed
neetu morwani’s picture

neetu morwani commented
StatusFileSize
new lazyloader_does_not-2458981-3.patch416 bytes

hi @legolasbo,
This patch has the custom event which can be triggered whenever a user wants to.
This patch would solves the problem of lazyloading with flexslider and views_slideshow. We just need to trigger the new custom event on click on navigation arrows in the custom javascript file.
Kindly review and let me know in case of any feedback.
Thanks.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

@neetu morwani,

Thanks for the patch, I think it could be a good way to trigger the lazyloading of images for people who are comfortable writing their own code. However I'm looking to integrate the module in a way that no custom coding is required. Also I would like to not only load the image which is currently viewed, but also the image that will be next up. That way we can prevent the end user from noticing the images are lazyloaded all together.

geerlingguy’s picture

geerlingguy commented

Also I would like to not only load the image which is currently viewed, but also the image that will be next up.

That sounds great! If the module is invisible to the end user (at least on decent Internet connections), that's a major win!

I think it could be a good way to trigger the lazyloading of images for people who are comfortable writing their own code. However I'm looking to integrate the module in a way that no custom coding is required.

It seems many times this module is in use, people are trying to integrate it with some custom-coded image rotator or something of the like, so it would be nice if it works as well as it can with as many modules as possible out-of-the-box, but it's also nice to have an event to use to integrate with custom-coded solutions (for better flexibility), so something like this patch gets a +1 from me :)

Thanks for your work on this module!

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

It seems many times this module is in use, people are trying to integrate it with some custom-coded image rotator or something of the like, so it would be nice if it works as well as it can with as many modules as possible out-of-the-box, but it's also nice to have an event to use to integrate with custom-coded solutions (for better flexibility), so something like this patch gets a +1 from me :)

I'm thinking of an implementation along these lines.

  1. Implement the event suggested in #3 for ease of integration for custom implementations.
  2. Add integrations for Flexslider/views_slideshow/etc. on a case by case basis by using the event suggested in #3.
geerlingguy’s picture

geerlingguy commented

@legolasbo - that sounds perfect!

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Postponed » Active
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Active » Needs review

Marking needs review as a reminder that this issue has a patch.

socialnicheguru’s picture

socialnicheguru commented

Where is "jquery.lazyloader.js"? It is not in the module file for 7.2.x Oct 2015.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

@SocialNicheGuru

I'ts not there because jquery.lazyloader.js was the custom lazyloading implementation used in 7.x-1.x. In the 7.x-2.x branch it has been removed in favour of the echo library.