Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
statistics.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Mar 2015 at 17:34 UTC
Updated:
20 Oct 2015 at 01:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirPatch was created on an older core version, let's see if this still applies.
Comment #2
timmillwoodComment #3
berdirCompletely forgot about this one, thanks for the RTBC :)
Note: Adding a test for this would require a test theme with a node template that doesn't contain {{ content }}, that quite some effort.
Comment #4
timmillwoodRight, because there's no proper tests I'll look out for bug reports.
Comment #5
alexpottRe #3 this this like pretty important functionality for the statistics module and probably something that should be tested. #2385243: Make core user fields available for twig templates added a test theme for a similar reason - didn't seem like too much work.
Comment #6
thenchev commentedWorking on it.
Comment #7
timmillwoodGreat start @Denchev thanks for the work on this!
Comment #8
thenchev commentedComment #9
slashrsm commentedFew cosmetic comments:
s/block_test_theme/statistics_test_attached
Copy-paste kind of thing I assume.
Is there a way to avoid using the global here?
Maybe asserting just statistics.js? Something like:
I think we don't need this entire comment block in a template that is used for testing purposes only.
Comment #10
thenchev commented9.2) Yup, missed that somehow
Also this should fix everything else.
Comment #11
berdirLooks good now I think.
Comment #12
alexpottThis is a normal bug fix that is not disruptive and therefore permitted during beta. Committed bfdc741 and pushed to 8.0.x. Thanks!