Remove Utility\String class

Let's remove the class in one go.

Removing the class in one go means that the bc layer hangs around for longer which is good for contrib.

Disregard #4, seems I may have run a faulty sed regex there!

I think this was intended to be postponed on #2457887: Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions. This is *only* supposed to remove the class itself.

On both #2457781: Use Utility\Html class instead of Utility\String for decodeEntities() function and #2457887: Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions then I guess. Even after resolving conflicts between these and applying them there are still going to be some stray unused "use Utility/String" statements as well.

Seems like this patch accidently rolled all of these 3 issues into 1 big patch :)

Changing parent, so all these issues are visible in the php7 meta issue.

This will require a reroll after #2457781: Use Utility\Html class instead of Utility\String for decodeEntities() function still so we can get rid of any stray unused "use Utility/String" statements...

This should only be done after the next beta to give contrib and custom time to update their code.

Change record is here: https://www.drupal.org/node/2457593

Looks like unused "use Utility/String" statements are being removed here: #2462151: Remove unused Utility\String use statements

Just so PHP7 doesn't choke on the next Drupal 8 beta, what about this as a stop-gap solution before we remove the class entirely?

whitespace fix

+++ b/core/lib/Drupal/Component/Utility/String.php
@@ -7,98 +7,105 @@
+// String is a reserved word as of PHP version 7.
+if (version_compare(PHP_VERSION, '7.0-dev', '<')) {
...
+  class String {
...
+    public static function checkPlain($text) {
...
+    public static function decodeEntities($text) {
...
+    public static function format($string, array $args = array()) {
...
+    public static function placeholder($text) {

PHP 7-dev does not have this methods, so just remove the file and postpone the issue

And as long as we don't use the class - which we're not then PHP7 will run D8 just fine.

Ah never mind then, I thought the mere class definition would be problematic!

probably it's time

Nope - not until after the next beta please - which is 29th April... https://groups.drupal.org/node/466823

Yep, sounds good.

Committed and pushed to 8.0.x. Thanks!