Blocks #606840: Enable internal page cache by default.

CommentFileSizeAuthor
#4 interdiff.txt1.52 KBwim leers
#4 cron_run_test-2458289-4.patch1.54 KBwim leers
#1 cron_run_test-2458289-1.patch847 byteswim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Issue tags: +Quickfix
StatusFileSize
new cron_run_test-2458289-1.patch847 bytes
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Can't we just move the following lines up to here - doing less logins in the test?

    $admin_user = $this->drupalCreateUser(array('administer site configuration'));
    $this->drupalLogin($admin_user);
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new cron_run_test-2458289-4.patch1.54 KB
new interdiff.txt1.52 KB

Well-spotted, Sir!

Done.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Test only change - permitted in beta. Committed 0880f31 and pushed to 8.0.x. Thanks!

  • alexpott committed 0880f31 on 8.0.x 
    Issue #2458289 by Wim Leers: CronRunTest::testAutomaticCron() should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.