Problem/Motivation

/autoload.php was introduced in #2406681: Add an autoload.php in the repo root to control the autoloader of front controllers but there still direct calls to core/vendor/autoload.php this causes trouble in composer based projects.

Proposed resolution

Remove calls to core/vendor/autoload.php in favour of /autoload.php

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 d8-autoload-2458045-7.patch7.11 KBwebflo
#6 d8-autoload-2458045.interdiff.txt872 byteswebflo
#6 d8-autoload-2458045-6.patch7.77 KBwebflo
#1 d8-autoload-2458045.patch6.16 KBwebflo

Comments

webflo’s picture

webflo commented
StatusFileSize
new d8-autoload-2458045.patch6.16 KB

Status: Needs review » Needs work

The last submitted patch, 1: d8-autoload-2458045.patch, failed testing.

webflo’s picture

webflo commented
Issue summary: View changes
Status: Needs work » Needs review

webflo queued 1: d8-autoload-2458045.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: d8-autoload-2458045.patch, failed testing.

webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new d8-autoload-2458045-6.patch7.77 KB
new d8-autoload-2458045.interdiff.txt872 bytes
webflo’s picture

webflo commented
StatusFileSize
new d8-autoload-2458045-7.patch7.11 KB
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/lib/Drupal/Core/DrupalKernel.php
@@ -263,6 +263,9 @@ public static function createFromRequest(Request $request, $class_loader, $envir
+    if (!is_object($class_loader)) {
+      $debug = 1;
+    }

Feel free to remove it ...

Just had a quick look, all the instances of loading vendor/autoload.php are replaced.

webflo’s picture

webflo commented

Fix this in patch #7

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I'm blind

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I still find it odd that so many were missed by the original patch. alexpott--

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 8b2f85b and pushed to 8.0.x. Thanks!

  • alexpott committed 8b2f85b on 8.0.x 
    Issue #2458045 by webflo: Remove calls to core/vendor/autoload.php

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.