No template. The title is enough.

CommentFileSizeAuthor
#1 2457155_1.patch1.47 KBchx
vct.patch1.42 KBchx

Comments

chx’s picture

StatusFileSize
new1.47 KB

Whitespace.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

This improves the tests in various way:

a) they aren't bound to sql anymoe
b) they aren't bound to the table names / the fact that terms are translatable.

+++ b/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php
@@ -41,10 +41,11 @@ function testTaxonomyVocabularyDeleteWithTerms() {
+    ¶

Does someone want to fix the whitespace ;)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Tests are not frozen in beta. Committed d6ea076 and pushed to 8.0.x. Thanks!

diff --git a/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php b/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php
index cc80b2b..1c174d4 100644
--- a/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php
+++ b/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php
@@ -45,7 +45,7 @@ function testTaxonomyVocabularyDeleteWithTerms() {
 
     // Assert that there are no terms left.
     $this->assertEqual(0, $query->execute(), 'There are no terms remaining.');
-    
+
     $terms = array();
     for ($i = 0; $i < 5; $i++) {
       $terms[$i] = $this->createTerm($vocabulary);

Fixed on commit.

  • alexpott committed d6ea076 on 8.0.x
    Issue #2457155 by chx: VocabularyCrudTest is needlessly SQL bound
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.