Closed (fixed)
Project:
REST UI
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Mar 2015 at 12:02 UTC
Updated:
7 Jun 2016 at 23:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
clemens.tolboomChanging this core method (killing kittens) back to public makes Rest UI work.
Comment #2
clemens.tolboomI've added a patch to core issue. Hope that gets in soon.
Comment #3
clemens.tolboomAttached patch is only useful when #2456303: AuthenticationManager needs interface and ::getProviderKeys lands.
Comment #4
znerol commentedAs pointed out by @alexpott in #2456303-16: AuthenticationManager needs interface and ::getProviderKeys a better way to collect the keys is to just collect them from the container using a service collector. Note that we currently are working on #2432585: Improve authentication manager service construction to support custom global service providers, please chime in over there.
Comment #5
clemens.tolboom@znerol thanks for the feedback.
@alexpott
Not sure what this means yet :-/ Feedback is welcome.
Comment #6
znerol commentedaddProvider($id)getProviderKeys()service_collectortag to the service with the newaddProvider()methodgetProviderKeys()from your own service wherever you wish.Example of the service definition:
Example of the class:
Note that we are planning to introduce explicit provider keys instead of the magic applied to the service id in #2432585. This will render theUpdate: #2432585: Improve authentication manager service construction to support custom global service providers landed,convertServiceIdToProviderKeymethod superflous.provider_idargument now can be used.Comment #7
clemens.tolboom@znerol awesome :-)
Comment #8
clemens.tolboomComment #9
clemens.tolboomI cannot test against latest core as mysql is too old now :-(
Attached patch needs work
Comment #10
mikey_p commentedSlightly renamed the collector and copied a few bits from the Authentication Manager over to make sure we get the same behavior.
Comment #12
clemens.tolboomThanks to @znerol + @mikey_p
Comment #13
clemens.tolboomI was too optimistic in stating fixed. We loosed the fatal which is good. See #2488496: UX + config quirks
Comment #14
clemens.tolboomI reopen this as when #2490228: Add Authentication Collector lands we need to revert this.
Comment #15
clemens.tolboom@znerol + @mikey_p please visit #2490228: Add Authentication Collector to make sure you get credits too.
Comment #16
andypostHere's a removal of custom collector in favour of core one that here since 8.0
PS: + additional code clean-up
Comment #18
clemens.tolboomThanks.
Comment #20
clemens.tolboom@andypost please create a new issue for the cleanup. I agree we need to rinse this but it definitely needs a new issue. Thanks!
Comment #21
andypost@clemens.tolboom Filed #2744445: Clean-up codebase according current code standards