The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.In the system_get_module_admin_tasks() function of system.module, $admin_tasks is initialized twice, first at about line 1344 and second at about line 1358. Nothing is done with the variable between the two initializations, so it's not a big deal, just unnecessary.
The attached patch eliminates the second one (and adds a blank line where it was, visually separating the two processes).
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | system_get_module_admin_tasks_2.patch | 1.01 KB | oadaeh |
| #5 | 245544.admin_tasks.patch | 1.01 KB | dave reid |
| system_get_module_admin_tasks.patch | 611 bytes | oadaeh |
Comments
Comment #1
drupalgeek commentedhow we use imagefield module for drupal6
Comment #2
damien tournoud commented@drupalgeek: that's not the place to ask a question like this. Please see http://drupal.org/support
Comment #3
lilou commentedPatch still applies against CVS/HEAD.
Comment #4
lilou commentedComment #5
dave reidHere's a revised patch that moves some variable initialization around so they're grouped together and make more sense.
Comment #6
oadaeh commented@Dave Reid: your patch adds a line with only two spaces in it. I've attached one that fixes that.
Comment #7
dave reidGood catch oadaeh! Patch applies cleanly, passes and RTBC.
Comment #8
dries commentedGood catch. Committed to CVS HEAD. Thanks folks!
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.