Follow-up to #2414235: Upgrade to Symfony 2.6.4 and #2377281: Upgrade to Symfony 2.6 stable.

Symfony 2.6.5 is out. I think we should upgrade since we are tracking stables. This is major as this is a minor external library upgrade. This should be a quickfix, so I don't think there would be a problem.

In #2414235: Upgrade to Symfony 2.6.4, we found that tests failed upon upgrading to 2.6.4. This issue basically tests the same. If tests fail, then this issue should be critical.

Note: From the changelog, it seems there are security related fixes/improvements which may or may not be applicable to us. One of it was related to XSS. But it is still a good idea to update.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is an external library upgrade.
Issue priority Major because this is a minor external library upgrade.
Disruption Not disruptive.
CommentFileSizeAuthor
#1 upgrade_to_symfony_2_6_5-2454393-1.patch321.04 KBhussainweb

Comments

hussainweb’s picture

hussainweb
Primary language English
commented
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new upgrade_to_symfony_2_6_5-2454393-1.patch321.04 KB

Upgrading to Symfony 2.6.5. Also marking this as major as per IS. If the tests fail, then this issue should be critical.

hussainweb’s picture

hussainweb
Primary language English
commented

Okay, the tests pass. We should be good for an upgrade any time.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah, no test failures!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a2a1c6a and pushed to 8.0.x. Thanks!

The patch in #1 contains a difference if I do the update myself. Rather than change file mode's ourselves we should file an upstream file for core/vendor/symfony/dom-crawler/Symfony/Component/DomCrawler/Tests/CrawlerTest.php

diff upgrade_to_symfony_2_6_5-2454393-1.patch alex.patch
3063c3063,3065
< index 9471d54..f51c56a 100755
---
> old mode 100755
> new mode 100644
> index 9471d54..f51c56a

  • alexpott committed a2a1c6a on 8.0.x 
    Issue #2454393 by hussainweb: Upgrade to Symfony 2.6.5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.