Follow-up to #2414235: Upgrade to Symfony 2.6.4 and #2377281: Upgrade to Symfony 2.6 stable.
Symfony 2.6.5 is out. I think we should upgrade since we are tracking stables. This is major as this is a minor external library upgrade. This should be a quickfix, so I don't think there would be a problem.
In #2414235: Upgrade to Symfony 2.6.4, we found that tests failed upon upgrading to 2.6.4. This issue basically tests the same. If tests fail, then this issue should be critical.
Note: From the changelog, it seems there are security related fixes/improvements which may or may not be applicable to us. One of it was related to XSS. But it is still a good idea to update.
Beta phase evaluation
Issue category | Task because it is an external library upgrade. |
---|---|
Issue priority | Major because this is a minor external library upgrade. |
Disruption | Not disruptive. |
Comment | File | Size | Author |
---|---|---|---|
#1 | upgrade_to_symfony_2_6_5-2454393-1.patch | 321.04 KB | hussainweb |
Comments
Comment #1
hussainwebUpgrading to Symfony 2.6.5. Also marking this as major as per IS. If the tests fail, then this issue should be critical.
Comment #2
hussainwebOkay, the tests pass. We should be good for an upgrade any time.
Comment #3
dawehnerYeah, no test failures!
Comment #4
alexpottCommitted a2a1c6a and pushed to 8.0.x. Thanks!
The patch in #1 contains a difference if I do the update myself. Rather than change file mode's ourselves we should file an upstream file for
core/vendor/symfony/dom-crawler/Symfony/Component/DomCrawler/Tests/CrawlerTest.php