Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is a minor side issue which arose at the tail end of #1816764: Add missing type hinting to Contextual module docblocks
Normally with these bug/issues the documentation no longer described the actual implementation.
This one is in reverse...
here is a code cut and past from https://www.drupal.org/node/1816764#comment-9703923
The functions current returns null.
+++ b/core/modules/contextual/src/Tests/ContextualDynamicContextTest.php
@@ -134,8 +137,6 @@ function testDifferentPermissions() {
- *
- * @return bool
*/
protected function assertContextualLinkPlaceHolder($id) {
@@ -146,8 +147,6 @@ protected function assertContextualLinkPlaceHolder($id) {
- *
- * @return bool
*/
protected function assertNoContextualLinkPlaceHolder($id) {
Beta phase evaluation
| Issue category | Bug because assertions should always return bool. |
|---|---|
| Issue priority | Normal because it's not breaking anything. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Prioritized changes | None |
| Disruption | None |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2453931-1.patch | 1.54 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedAdded the returns and fixed the comments.
Also added a beta eval to the summary.
Edit: I only just noticed that you assigned this issue to yourself while making it. I'm sorry, hope you didn't start fixing this yet :/
Comment #2
martin107 CreditAttribution: martin107 commentedAh no problem, I was interrupted.
Its looks good to me. I won't RTBC my own issue... but try and trade reviews with someone in IRC tomorrow.
Comment #3
geertvd CreditAttribution: geertvd at XIO commentedLooks like the sane thing to do.
Comment #4
alexpottTest only change is permitted in beta. Committed 7480281 and pushed to 8.0.x. Thanks!