Request/Response policies can be made private, assuming they do not need to be called directly (like KillSwitch).
Make the response policies in node, image and the request policy in basic_auth private.
See #2429671: "The website has encountered an error. Please try again later." page is cached for an example.
We could even consider to remove the DefaultRequestPolicy, that would actually require one class less, not sure if there's also a security reason for having it.
| Issue category | Task because nothing is broken |
|---|---|
| Issue priority | Normal |
| Prioritized changes | Small performance improvement, we save a few container rountrips (method calls) |
| Disruption | Services are no longer available from outside the service. But they do not offer any public methods except the server listeners, so nobody should have been calling them. |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | private-request-response-policy-services-2453711-3.patch | 1.49 KB | bogdan.racz |
Comments
Comment #1
wim leersWe should ping @znerol for that.
Comment #2
bogdan.racz commentedComment #3
bogdan.racz commentedUpdated the specified request and response policy services to make them private.
Not sure about the DefaultRequestPolicy removal. I can update the patch if I get a confirmation regarding that.
Comment #4
bogdan.racz commentedComment #5
bogdan.racz commentedComment #6
fabianx commentedRTBC, but needs a beta eval. Assigning to Wim for final review / beta eval.
Comment #7
berdirAdded a beta evaluation, looks good to me as well.
Comment #8
fabianx commentedRTBC + 1, beta eval looks good
Comment #9
wim leersBenchmarking the page cache/anon user with this, I'm seeing a very slight improvement, but with the margin of error. Pretty much status quo. But that's fine.
RTBC +1
Comment #10
alexpottCommitted ec8033c and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.