API documentation shows that hook_view() takes two parameters, the node and the view mode. However, node_build_content() shows hook_view() being invoked with three parameters, the third being the $langcode.

CommentFileSizeAuthor
#4 2453389-4.patch1022 bytesrpayanm
#4 2453389-interdiff.txt560 bytesrpayanm
#2 2453389-hook-view-langcode-documentation-2.patch1017 bytesjoshi.rohit100

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: +Novice

Agreed, good catch! Just needs a patch. Note: doesn't exist in Drupal 8.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2453389-hook-view-langcode-documentation-2.patch1017 bytes

Updated. Took the $langcode documentation from node_build_content().

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Looks good, thanks! Can you add a blank line between the last @param and the @return?

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2453389-interdiff.txt560 bytes
new 2453389-4.patch1022 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 437ceb6 on 
    Issue #2453389 by rpayanm, joshi.rohit100: hook_view() does not document...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.