Maintenance mode message ends up in page cache, served endlessly

Looks great!

We will have a test for this once, enable page cache by default is in.

Oh that was such a annoying problem in earlier versions of Drupal!!

Talked this over with alexpott in IRC. Since this issue is fixing a critical, and the other is only a major task, we should copy in whatever test coverage uncovered this bug from that issue over here.

Talked this over with alexpott in IRC. Since this issue is fixing a critical, and the other is only a major task, we should copy in whatever test coverage uncovered this bug from that issue over here.

Well, the test coverage is by enabling page caching for most tests.

I agree with #5: this could use explicit test coverage both with and without page cache, that is independent of what our default happens to be.

Here's the test addition for that. Leaving the issue at RTBC, because this only changes test code (the test-only patch is also the interdiff), that can be sufficiently sanity checked by whichever core committer looks at this. Plus, anything that slips through their review can be addressed in a non-critical follow-up.

Related issue bump: #2429671: "The website has encountered an error. Please try again later." page is cached. If this is critical then the other one might be too?

Yeah, good point. Tentatively escalated that one to critical as well.

In the mean time, let's get this one out of the way. Thanks for the tests!

Committed and pushed to 8.0.x. Thanks!

This seem to happen with Drupal 7 too, can someone confirm ?

I am sorry I shouldn't have changed the version.