Follow-up on #2417983: Change docs instances of "the the" to "the": there are two more instances of "the the" in the codebase. Patch to follow.

Beta eval This is just docs. Not frozen.

CommentFileSizeAuthor
#8 2453311-8.patch5.53 KBrpayanm
#6 change-double-the-the-to-simple-the-2453311-6.patch7.6 KBdom.
#5 issue_2417983-2453311-5.patch1.28 KBDavid_Rothstein
#1 issue_2417983-2453311-1.patch1.13 KBtraviscarden

Comments

traviscarden’s picture

traviscarden commented
Assigned: traviscarden » Unassigned
Status: Active » Needs review
StatusFileSize
new issue_2417983-2453311-1.patch1.13 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed e765be0 on 7.x 
    Issue #2453311 by TravisCarden: Fix a couple more "the the"s in the...
David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.0.x-dev
Status: Fixed » Needs review
StatusFileSize
new issue_2417983-2453311-5.patch1.28 KB

Well actually there's a bit of overlap with Drupal 8 there - let's fix it in Drupal 8 too.

dom.’s picture

dom. commented
StatusFileSize
new change-double-the-the-to-simple-the-2453311-6.patch7.6 KB

Actually it happens much more than just in ConditionInterface as per patch #5. I found 13 in total while reviewing.
Patch proposal joined.

David_Rothstein’s picture

David_Rothstein commented
Title: Issue #2417983 follow-up: two more "the the"s » Issue #2417983 follow-up: a few more "the the"s
Status: Needs review » Needs work

Nice find!

However, the ones in core/vendor should not be changed since those are external libraries. (The fix for those would need to be done upstream and then pulled into Drupal the next time Drupal gets a new version of the library.) So they should be removed from the patch.

Also for a couple of the others, a minor issue is that after removing the duplicate "the", more words can now fit on the line and still be under the 80 character limit. For example:

--- a/core/modules/system/core.api.php
+++ b/core/modules/system/core.api.php
@@ -1483,7 +1483,7 @@
  *
  * Alternatively, forms can be built directly via the routing system which will
  * take care of calling \Drupal::formBuilder()->getForm(). The following example
- * demonstrates the use of a routing.yml file to display a form at the the
+ * demonstrates the use of a routing.yml file to display a form at the
  * given route.

Certainly at least "given" can move up to the previous line in this case.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2453311-8.patch5.53 KB
dom.’s picture

dom. commented
Status: Needs review » Reviewed & tested by the community

Patch from #8 reviewed :
- manually applied it
- manually checked the 80 characters of all changes in the patch
- manually check that all remaining "the the" are in core/vendor (as per said by David_Rothstein in #7)
Therefore, patch #8 is RTBC +1 for me !

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

+1, thanks for patching/reviewing!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue summary: View changes

beta eval

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 720f586 and pushed to 8.0.x. Thanks!

  • alexpott committed 720f586 on 8.0.x 
    Issue #2453311 by David_Rothstein, TravisCarden, Dom., rpayanm: Issue #...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.