I found some odd behavior in aggregator module. When switching between the View, Categorize and Configure tabs on an aggregator category, the breadcrumbs are constantly shifting:

Home › Feed aggregator › Categories › Categories
Home › Feed aggregator › Categories › Test category › Categories
Home › Feed aggregator › Categories › Test category

Only the last one (Configure tab) is correct.

CommentFileSizeAuthor
#14 aggregator-source-title-14.patch960 bytesmustafau
#6 aggregator-source-title.patch970 bytesmustafau
#3 aggregator-breadcrumb-245322-3.patch2.61 KBmustafau
#1 aggregator.categories.breadcrumb.patch947 bytesmfb

Comments

mfb’s picture

mfb
they or he
commented
Version: 6.2 » 6.x-dev
Component: menu system » aggregator.module
Status: Active » Needs review
StatusFileSize
new aggregator.categories.breadcrumb.patch947 bytes

I was able to resolve the issue with the attached patch, which removes the drupal_set_breadcrumb() call.
Seems like there is no reason for the call to be there?

mustafau’s picture

mustafau commented
Version: 6.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

Applies to 7.x. RTBC.

mustafau’s picture

mustafau commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new aggregator-breadcrumb-245322-3.patch2.61 KB

I have found that breadcrumbs are not being displayed properly on "Sources" page either. Attached patch offers a workaround. I wonder if this can be fixed using menu system.

mustafau’s picture

mustafau commented
Status: Needs review » Reviewed & tested by the community

I should not hold this issue. Patch at #1 is RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

I've committed the patch in #1 to CVS HEAD and DRUPAL-6. I'm marking this 'code needs work' for the related issue in comment #3.

mustafau’s picture

mustafau commented
Title: repeated breadcrumbs and inconsistent behavior in local tasks » Repeated breadcrumbs and inconsistent behavior in local tasks
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new aggregator-source-title.patch970 bytes

Menu system is great.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Was never actually reviewed.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

lilou’s picture

lilou commented
Status: Needs review » Reviewed & tested by the community

Back to #7

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

mustafau’s picture

mustafau commented
Status: Needs work » Needs review

Still applies.

Status: Needs review » Needs work

The last submitted patch failed testing.

mustafau’s picture

mustafau commented
Status: Needs work » Needs review
StatusFileSize
new aggregator-source-title-14.patch960 bytes

Status: Needs review » Needs work

The last submitted patch failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Closed (cannot reproduce)

The breadcrumb doesn't seem to be set on aggregator pages anymore.