Problem/Motivation

The function drupal_pre_render_link() is marked as @deprecated, but doesn't specify whether it's deprecated for D8 or D9.

Proposed resolution

Based on maintainer's comments in #7, this function should be marked as deprecated for D9.

@deprecated in Drupal 8.x, will be removed before Drupal 9.0.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because things aren't broken, just in need of deprecation.
Issue priority Normal because we could leave this in and it wouldn't change much.
Prioritized changes This issue clarifies the deprecation status of drupal_pre_render_link()
CommentFileSizeAuthor
#8 2452491_8.patch574 bytesMile23
#2 drupal-remove-deprecated-function-drupal_pre_render_link-2452491-1.patch597 bytesarpitr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arpitr’s picture

arpitr CreditAttribution: arpitr commented
Issue summary: View changes
arpitr’s picture

arpitr CreditAttribution: arpitr commented
Assigned: arpitr » Unassigned
Priority: Normal » Minor
Status: Active » Needs review
FileSize
drupal-remove-deprecated-function-drupal_pre_render_link-2452491-1.patch597 bytes

Patch to remove the deprecated function definiton.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.0.0-beta7 » 8.0.x-dev
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

This a Drupal 7 function - either some change record needs updating or one needs creating

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue tags: -Needs change record

Actually given that this was not marked for 8.x removal lets just update the comment to say it will be removed in 9.0.0. No unnecessary API changes we're in beta.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Title: Remove deprecated function drupal_pre_render_link() definition » @deprecate drupal_pre_render_link() for Drupal 9
Issue summary: View changes
FileSize
2452491_8.patch574 bytes

Updated the issue summary, and here's a patch.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Needs review

oops.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 34d780b and pushed to 8.0.x. Thanks!

  • alexpott committed 34d780b on 8.0.x 
    Issue #2452491 by arpitr, Mile23: @deprecate drupal_pre_render_link()...

Status: Fixed » Needs work

The last submitted patch, 8: 2452491_8.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.