Currently all of the following preprocess functions are contained in a themeable group:

Preprocess functions shouldn't be in the themeable documentation group. Preprocess functions that are mistakenly added as part of the themeable group show up in which we don't want.

Documentation standards references:

Proposed resolution

Remove the @addtogroup that is currently wrapping all of the above preprocess functions as well as theme_indentation(), and just add an @ingroup themeable line to theme_indentation() instead.

Remaining tasks

  • Create patch
  • Review patch

Beta phase evaluation

Issue category Bug because it doesn't mesh with our existing coding standards for preprocess functions
Issue priority Normal
Unfrozen changes Unfrozen because it only changes documentation
Prioritized changes This is not a prioritized change for the beta phase.
Disruption No disruption for core or contrib.

User interface changes


API changes


#2 2452371-2.patch993 bytesPalashvijay4O
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 89,495 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


Cottser’s picture

Issue summary: View changes

Moving things around a bit.

Palashvijay4O’s picture

993 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 89,495 pass(es). View

Attached a patch.

Palashvijay4O’s picture

Status: Active » Needs review

Oops!! Changing the status now....

Cottser’s picture

Title: Remove @addtogroup themeable from, only theme_indentation needs it » Remove @addtogroup themeable from, only theme_indentation() needs it
Status: Needs review » Reviewed & tested by the community

Looks perfect, thanks @Palashvijay4O!

Cottser’s picture

Issue summary: View changes

Adding missing word to issue summary.

jhodgdon’s picture


alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Doucmentation is not frozen in beta. Committed 0c70a3a and pushed to 8.0.x. Thanks!

  • alexpott committed 0c70a3a on
    Issue #2452371 by Palashvijay4O: Remove @addtogroup themeable from theme...
Cottser’s picture

After the API page got updated, I noticed some more housekeeping that can be done: #2457271: More cleanup of the 'themeable' documentation group

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.