Follow-up to #2419015: Remove use of base: scheme in LocalTasksTest

Should be

* @param array $routes

Instead of

* @param array $hrefs
CommentFileSizeAuthor
#5 minor_phpdoc_issue_with-2451603-5.patch858 bytesnlisgo
#5 interdiff-2451603-1-5.txt820 bytesnlisgo
#1 minor_phpdoc_issue_with-2451603-1.patch783 bytesnlisgo

Comments

nlisgo’s picture

nlisgo commented
StatusFileSize
new minor_phpdoc_issue_with-2451603-1.patch783 bytes
nlisgo’s picture

nlisgo commented
Priority: Normal » Minor
nlisgo’s picture

nlisgo commented

It would be great if we could run PHP Codesniffer on the dev branch periodically and we could open up an issue to take care of a number of minor things in one go.

dawehner’s picture

dawehner
Primary language German
commented

+1

You could typehint to 

+++ b/core/modules/system/src/Tests/Menu/LocalTasksTest.php
@@ -22,9 +22,9 @@ class LocalTasksTest extends WebTestBase {
+   * @param array $routes
+   *   A list of expected routes of local tasks to assert on the page (in the
+   *   given order).

It would be great to explain what $routes is. Its an array of pairs of $route_name, $route_parameters.

nlisgo’s picture

nlisgo commented
StatusFileSize
new interdiff-2451603-1-5.txt820 bytes
new minor_phpdoc_issue_with-2451603-5.patch858 bytes
dawehner’s picture

dawehner
Primary language German
commented
Component: menu system » documentation
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Incorrect documentation is a bug. Documentation is not frozen in beta. Committed 87ade2e and pushed to 8.0.x. Thanks!

  • alexpott committed 87ade2e on 8.0.x 
    Issue #2451603 by nlisgo: Minor PHPDoc issue with LocalTasksTest::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.