Followup to #2090115: Don't install a module when its default configuration has unmet dependencies

Collections can declared that they support configuration entities however config entity storage is completely unaware of collections. Collections are only used to store config override information by core. I think we should simplify code by removing the ability to support loading and creating config entities in collections.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because config entity storage is unaware of collections - thereby breaking static caching
Issue priority Normal because the functionality is currently unused and untested - which is another good reason to remove.
Files: 
CommentFileSizeAuthor
#3 2451359.3.patch10.88 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 96,138 pass(es). View
#1 2451359.1.patch9.49 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,702 pass(es). View

Comments

alexpott’s picture

Status: Active » Needs review
FileSize
9.49 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,702 pass(es). View

Removed the fake ability of collection's other than the default to support config entities.

alexpott’s picture

Issue summary: View changes
alexpott’s picture

FileSize
10.88 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 96,138 pass(es). View

Rerolled.

I think removing this is good also because reducing functionality will reduce possible bugs.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Yes, this makes sense.

We've discussed this a while back already, while working on #2090115: Don't install a module when its default configuration has unmet dependencies.

This removes a method from a public interface, but I doubt it's one that anyone ever called or implemented, since it doesn't really work.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Yes agreed. And not really an API change if the API has never, ever worked.

Committed/pushed to 8.0.x, thanks!

  • catch committed b3a3555 on 8.0.x
    Issue #2451359 by alexpott: Remove the ability of collections other than...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.