Drupal QA is broken for Views 7.x-3.x

Related #2415991: Scan for D8 tests breaks Views tests in D7, or fix path case-sensitivity and argument parsing

Same issue here:
https://qa.drupal.org/pifr/test/977228

Yeah, they have been broken for quite a while.

@dagmar
Is that issue the only problem we have, or can we fix something in views itself?

Is this likely to be fixed in the testbots or should views move its template file from tests/templates?

I'm 100% fine to move those test templates

Does anyone wants to propose a quick patch? That would be great!

Let see if this fixed this issue at least for now.

This is an issue with runtests.sh, which is part of core. This needs to be patched there.

I def didnt delete that patch. wth.

The patch looks pretty good., it would be great if it would work!

Actually, moving the templates to the tests/vendor/ directory should make the trick. Anyway I posted a new patch here https://www.drupal.org/node/2273481#comment-9759345 to fix this issue in the right place.

I was wrong about the 'proper place' to fix this. Im not entirely sure what the right way to fix this is in run-tests.sh, but this patch will definitely work to fix views testing for the time being.

According last comments of #2273481: Contrib PSR-4 PHPUnit tests are not picked up by PIFR this should be fixed on views instead of the PIFR system. @dawehner do you need any modification to the patch provided in #7.

@dawehner just signed off on this one so I just committed it. I'm assuming we can start testing all patches again?

Edit: I enabled the new testing system on the branch, which must pass before issue patches can be tested. It looks like 4 tests are failing. Can someone take a closer look?

Have You taken over the project? I'm just asking because I feel very unmotivated to share more patches if none has been committed 3-4 years after sharing them.

Have You taken over the project? I'm just asking because I feel very unmotivated to share more patches if none has been committed 3-4 years after sharing them.

@colan stepped up as a co-maintainer. As we all know, contributing is hard and there is a limited time, so someone
helping out properly is a good thing. Thank you @colan!

@hass: If you could help with those tests it would be greatly appreciated. As soon as we get those fixed, we can get all of the other RTBC patches rolling again. And I'm sure most of those will pass so we'll be able to commit them.

@colan: Perhaps it's worth creating follow up issues to fix those tests as people might miss it in this "fixed" issue

It's worth noting that the day before this was comitted, we had enabled drupalci testing for d7 projects, and that drupalci does not have an issue with finding tpl.php files or causing that to break views. So while this fixes pifr/pift, the days of pifr/pift are numbered and drupalci is where all effort is being focused.

Follow-up with child issues is now available over at #2610280: Fix QA test failures for Views branch 7.x-3.x. Please help fixing those if you can!