After committing #2398347: Panopoly Magic abuses FPP revisions the livepreview.feature is taking way to long - up to 15 minutes in some reports.

In my testing, everything appears to be running fine until a certain point in the following scenarios:

  • Page should match live preview after saving the widget but before saving the page
  • Live preview should work equally well with a reusable widget

And possibly others (I killed my test run before it got too far).

It appears like something is happening that's causing our check to see if AJAX has finished after each step to time out (causing a 5 second wait after each step) - but I haven't been able to confirm that yet.

CommentFileSizeAuthor
#2 panopoly_wysiwyg-slow-tests-2449495-2.patch734 bytesdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Yeah, it looks like jQuery.active is stuck at 1 because we get this error when saving the Text widget:

Uncaught TypeError: Cannot read property 'replace' of undefined

... in Drupal.wysiwyg.editor.attach.tinymce().

It appears it's trying to run Drupal.wysiwygAttach() on the WYSIWYG text area that is no longer present on the page.

I'm not sure yet what is causing this to happen. I thought it might be another regression from the CTools upgrade, but I reverted to 1.5 and 1.4 and neither helped.

These issues seem to be related, but the patches don't fix it:

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
Related issues: +#1757684: Ajax error on Add another item
StatusFileSize
new panopoly_wysiwyg-slow-tests-2449495-2.patch734 bytes

Aha! This patch to the 'wysiwyg' module appears to fix it:

#1757684: Ajax error on Add another item

Here's a patch to get that into panopoly_wysiwyg.make!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

With that patch, I'm able to run all of livepreview.feature locally in 2m40s! Committing.

  • dsnopek committed 2d775c5 on 7.x-1.x 
    Update Panopoly WYSIWYG for Issue #2449495 by dsnopek: livepreview....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.