Hi,
First thanks for the cool module :)
I had following problem with Elastic:
When I send the logged json to Elastic it creates new fields for each variable in variables property/array from $entry object (which are a lot) and also the message is with place holders.
Currently I handled this with adding an alter just before writing in the file (see attached image). That way I replaced the placeholders in the message with the info from variables property and unset variables property.
Can you suggest something better or add this alter option to the module?
BR,
Metodiy
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | jsonlog-replace-variables-into-message-2448753-5.patch | 9.84 KB | jacobfriis |
| jsonlog_entry-alter.png | 27.61 KB | mkozhuharov |
Comments
Comment #1
jacobfriis commented@mkozhuharov
Thx for your info and suggestion.
Replacement of variables in the message should rather be performed on demand by the log client.
Because replacement introduces an extra overhead. And that overhead is mostly redundant, because in the practical world nobody reads every single log entry.
But I'll check with the Elasticsearch guys at my workplace how they handle variables.
And an option for JSONlog to do the replacement sounds like a good idea.
Comment #2
jacobfriis commented@mkozhuharov
I believe you're right ;-) It doesn't make practical sense that ElasticSearch should replace variables into messages.
However, I'm not fond of drupal_alter'ing because of the overhead involved in hook invokation.
So with ...-2.patch JSONlog now does the job. And the feature is not a conf option, but mandatory - the module has enough options as it is.
The replacement is performed exactly the same way as format_string() does it - except JSONlog doesn't wrap replacements in placeholder HTML tags (because HTML is not really desirable in this context).
Comment #3
jacobfriis commentedThis patch is not compatible with: #2427723...-4.
Combined patch: jsonlog-combine-issues-2427723-and-2448753.patch
Comment #4
mkozhuharov commented@jacobfriis
Thanks for the patch :)
Comment #5
jacobfriis commentedOops, variable replacement should take place _before_ escaping.
Comment #7
jacobfriis commentedFixed in JSONlog 7.x-2.1.