Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

The focus of the issue is to remove usage and the function update_project_storage() from update.compare.inc

CommentFileSizeAuthor
#7 remove_usage_and-2448069-6.patch2.69 KBjeroent
#1 remove-usage-function-update_project_storage-2448069-1.patch2.62 KBa_thakur

Comments

a_thakur’s picture

a_thakur commented
Assigned: a_thakur » Unassigned
Status: Active » Needs review
StatusFileSize
new remove-usage-function-update_project_storage-2448069-1.patch2.62 KB

Please find the attached patch which fixes the issue.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

Patch looks good, but we still need a change record.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs change record
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

The test passed on March 7. Adding 'needs change record' tag though I'm not sure that's really necessary.

Retesting the patch in #1, which should change RTBC to Needs Work if it fails.

Patch removes update_project_storage() and useages (there's only one).

Thanks, folks!

Mile23 queued 1: remove-usage-function-update_project_storage-2448069-1.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/update/update.compare.inc
@@ -129,11 +129,10 @@ function update_process_project_info(&$projects) {
- * @see update_project_storage()

This just be replaced not removed. With an @see to the projectStorage method.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

Added reference to the projectStorage method.

Patch attached.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new remove_usage_and-2448069-6.patch2.69 KB
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Still applies, does change the @see from update_project_storage() to \Drupal\update\UpdateManagerInterface::projectStorage().

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Still need to attach a CR to this - maybe there is an existing one.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs change record

Added change to existing record for update_*() functions.: https://www.drupal.org/node/2430443

a_thakur’s picture

a_thakur commented

Thanks Mile23 for the change record.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ok, looks like this is in order now. Removing deprecated functions in explicitly allowed in beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 40c8a03 on 
    Issue #2448069 by a_thakur, JeroenT, Mile23: Remove usage and function...
a_thakur’s picture

a_thakur commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.