Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Audit our custom Behat code, find slow bits and optimize them! This would most likely be in a @beforeStep, @afterStep, or @beforeScenario.
Comment | File | Size | Author |
---|---|---|---|
#5 | panopoly_magic-optimize-behat-2447839-5.patch | 3.23 KB | dsnopek |
#5 | panopoly_test-optimize-behat-2447839-5.patch | 30.04 KB | dsnopek |
Comments
Comment #1
dsnopekHere is my first pass at optimizing!
EDIT: Trying on Travis-CI - this is my first attempt at running all the tests. Let's see what fails! https://travis-ci.org/panopoly/panopoly/builds/53430701
Comment #2
dsnopekRandom note to self: I think the code for "When I wait for live preview to finish" is broken, because it just takes too long. I suspect it's hitting the timeout, rather than actually detecting the condition.
Comment #3
dsnopekForgot to include the Panelizer default for the new test landing page content type! Here's a new patch.
EDIT: Here's the Travis-CI build: https://travis-ci.org/panopoly/panopoly/builds/53431367
Comment #4
dsnopekAnd one last one for the night! Undid change from earlier version of this patch.
EDIT: The Travis-CI build: https://travis-ci.org/panopoly/panopoly/builds/53431587
Comment #5
dsnopekHere is a new patch that make the "When I wait for live preview to finish" step actually work, rather than just waiting for the time. It required some changes to panopoly_magic, to make it actually possible to detect that the preview is reloading AND to make it's behavior more predictable (ie. I had to remove the special case for loading without delay on 'blur' because it meant that the live preview loaded twice for every field we filled in: once for filling it in and waiting, and once for the blur when we went on to the next one).
It works locally! I'll try on Travis-CI in a moment.
EDIT: Here's the build: https://travis-ci.org/panopoly/panopoly/builds/53457782
Comment #7
dsnopekThis is looking pretty amazing! The Behat test run time for the last run on Travis-CI was 17m21.524s for the Firefox tests. On the last successful test run on the main branch, this was 27m51.613s and I've seen it as high as 35 minutes when watching builds in the past. So, this is a pretty massive improvement!
Committed!
Comment #8
dsnopekHere's all the jobs after merging this change:
https://travis-ci.org/panopoly/panopoly/builds/53460086
Only the first 5 have run so far, but it's been a long time since I've seen a job take less than 30 minutes, which is pretty sweet. :-)