http://cgit.drupalcode.org/photo/tree/photo.info.yml?h=8.x-1.x is tripping up localize.drupal.org's cron:

WD php: Symfony\Component\Yaml\Exception\ParseException: Unable to       [error]
parse at line 1 (near "name = Photo"). in
Symfony\Component\Yaml\Parser->parse() (line 243 of
/var/www/localize.drupal.org/htdocs/sites/all/modules/potx/vendor/Symfony/Component/Yaml/Parser.php).
CommentFileSizeAuthor
#2 gracefully_handle_yaml-2447551-2.patch1.01 KBSebCorbin

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Title: Gracefully handle Yaml parse failiures » Gracefully handle Yaml parse failures
SebCorbin’s picture

SebCorbin commented
Status: Active » Needs review
StatusFileSize
new gracefully_handle_yaml-2447551-2.patch1.01 KB

Would that do?

drumm’s picture

drumm
he/him
Location NY, US
commented

I think so. I saw couple calls to Yaml::parse, and I don't have the backtrace, or familiarity with the codebase, to know which one exactly was the problem.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Looks good to me too.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed

  • SebCorbin committed 3b426d1 on 6.x-3.x authored by drumm 
    Issue #2447551 by SebCorbin, drumm: Gracefully handle Yaml parse...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Amazing, thanks @sebcorbin for the patch and the rollout!

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Patch (to be ported)
drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: +Localize D7 port

  • herom committed 3aa0d90 on 7.x-3.x authored by SebCorbin 
    Issue #2447551 by SebCorbin, drumm: Gracefully handle Yaml parse...
herom’s picture

herom commented
Status: Patch (to be ported) » Fixed

Committed directly to 7.x branch. The 7.x-3.x and 6.x-3.x branches are still closely following each other.

Thanks.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Yay, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.