warning from brilliant_gallery_get_picasa_hidden_imagenames() [#2446565]

function brilliant_gallery_get_picasa_hidden_imagenames() returns a non-existent array if the file "picasa.ini" doesn't exists.
This results in:
Notice: Undefined variable: filenames in brilliant_gallery_get_picasa_hidden_imagenames() (line 540 of /xxx/sites/all/modules/contrib/brilliant_gallery/brilliant_gallery_functions.inc).
and
Warning: in_array() expects parameter 2 to be array, null given in load_dir_to_array() (line 37 of /xxx/sites/all/modules/contrib/brilliant_gallery/brilliant_gallery_functions.inc).

Comment	File	Size	Author
#1	brilliant_gallery_2446565.patch	703 bytes	PROMES

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

PROMES

Dutch

CreditAttribution: PROMES commented 5 March 2015 at 13:23

File	Size
brilliant_gallery_2446565.patch	703 bytes

Attached a patch to correct the problem.

Comment #2

fchandler CreditAttribution: fchandler commented 18 May 2015 at 22:20

I applied this patch
got this message in the process.
patching file /var/www/html/nellchandler.com/sites/all/modules/brilliant_gallery/brilliant_gallery_functions.inc
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 501 with fuzz 1.
Don't know what any of that means, but the error message is gone.

Comment #3

fkelly12054@gmail.com CreditAttribution: fkelly12054@gmail.com as a volunteer commented 25 May 2015 at 16:02

I'm not familiar with the patching process. The problem with the brilliant_gallery_get_picasa_hidden_imagenames function as originally written, is that the variable $filenames does not get defined unless there is a picasa.ini file. The patch appears to add:

$filenames = array();

right after the function declaration so that it will always be defined at the time that the return statement is executed at the end of the function. That's all that's needed.

There does appear to be a superfluous declaration of $filenames at line 503 of the current program. I don't think it will do any harm but probably best to get rid of it.

I know the "official" thing to do is to patch the files, but personally I'd just save off a backup copy of the program and then edit it directly.