Media Vimeo has a very bad bug that can cause an unhandled exception to be thrown if the oEmbed endpoint returns an error. This is a patch to patch Media Vimeo.

CommentFileSizeAuthor
#2 media_vimeo_patch_to-2446219-2.patch411 bytesmglaman
#1 media_vimeo_patch_to-2446219-1.patch411 bytesmglaman

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new media_vimeo_patch_to-2446219-1.patch411 bytes

Patch attached. Working on my testing still.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new media_vimeo_patch_to-2446219-2.patch411 bytes

Updated patch to Media Vimeo to include image formatters.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: mglaman » Unassigned
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Trying on Travis-CI just in case: https://travis-ci.org/panopoly/panopoly/builds/53462946

  • dsnopek committed 48af754 on 7.x-1.x 
    Update Panopoly Widgets for Issue #2446219 by mglaman: Media Vimeo patch...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tests pass and we discussed this change at the sprint. Looks good to me! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.